JAVA.STMT.IFELSE.BLOCK

The body of an if/else statement must be a block between {and}.

Vulnerability and risk

Omitting the curly braces in the body of an if/else statement can result in inadvertent programming errors.

Mitigation and prevention

Use curly braces in the body of the if/else statement.

Example 1

Copy

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
public class C18 {
    
    public void doSomething() {
        
    }
    
    public void testNGIf(int some_number) {
        
        if (some_number == 1)
            doSomething(); //NG
        else if (some_number == 2)
            doSomething(); //NG
        else
            doSomething(); //NG
        
        
        if (some_number == 3); //NG
        else if (some_number == 4); //NG
        else; //NG
        
    }
    
    public void testOKIf(int some_number) {
        
        if (some_number == 1) {
            doSomething();
        } else if (some_number == 2) {
            doSomething();
        } else {
            doSomething();
        }
    }
    
}