CS.SV.TRANSP.SUCSA

Transparent methods should not be decorated with the SuppressUnmanagedCodeSecurityAttribute.

Methods decorated with the SuppressUnmanagedCodeSecurityAttribute attribute have an implicit LinkDemand placed upon any method that calls it. This LinkDemand requires that the calling code be security critical. Marking the method that uses SuppressUnmanagedCodeSecurity with the SecurityCriticalAttribute attribute makes this requirement more obvious for callers of the method.

Mitigation and prevention

To fix a violation of this rule, mark the method or type with the SecurityCriticalAttribute attribute.

Vulnerable code example

Copy

2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
  using System;
  using System.Runtime.InteropServices;
  using System.Security;
  
  namespace TransparencyWarningsDemo
  {
  
      public class SafeNativeMethods
     {
         // CA2145 violation - transparent method marked SuppressUnmanagedCodeSecurity.  This should be fixed by 
         // marking this method SecurityCritical.
         [DllImport("kernel32.dll", SetLastError = true)]
         [SuppressUnmanagedCodeSecurity]
         [return: MarshalAs(UnmanagedType.Bool)]
         internal static extern bool Beep(uint dwFreq, uint dwDuration);
     }
 }