DBZ.CONST.CALL

Zero constant value is passed to a function and might be used in a division by zero

An attempt to do a division or modulo operation using zero as the divisor causes a runtime error. Division by zero defects often occur due to ineffective error handling or race conditions, and typically cause abnormal program termination. Before a value is used as the divisor of a division or modulo operation in C/C++ code, it must be checked to confirm that it is not equal to zero.

The DBZ checkers look for instances in which a zero constant value is used as the divisor of a division or modulo operation.

The DBZ.CONST.CALL checker flags situations in which an explicit zero constant value is passed directly to a function call and might be used as a divisor of a division or modulo operation without checking it for the zero value.

Vulnerability and risk

Integer division by zero usually result in the failure of the process or an exception. It can also result in success of the operation, but gives an erroneous answer. Floating-point division by zero is more subtle. It depends on the implementation of the compiler. If the compiler is following the IEEE floating-point standard (IEEE 754), then the result of the floating-point division by zero has a well-defined result. However, the C and C++ standards do not enforce compliance to IEEE 754. Thus, floating-point division by zero has an undefined behavior in C and C++ and might result in the failure of the process or an exception.

Division by zero issues typically occur due to ineffective exception handling. To avoid this vulnerability, check for a zero value before using it as the divisor of a division or modulo operation.

Vulnerable code example

Copy

1
2
3
4
5
6
7
8
9
10
11
12
13
  int compute_mean(int array[], size_t size)
  {
      int sum = 0;
      for (size_t i = 0; i < size; ++i) {
          sum += array[i];
      }
      return sum / size;
  }

 void use_mean()
 {     
     int mean = compute_mean(0, 0);
 }

Klocwork produces an issue report at line 11 indicating that the zero constant value is passed directly to the function 'compute_mean' and it is used in this function as the divisor of the division operation on line 7. A division by zero can produce unexpected and unintended results.

Fixed code example

Copy

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
  int compute_mean(int array[], size_t size)
  {
      if (size == 0) {
          return 0;   // or exceptional case.
      }

      int sum = 0;
      for (size_t i = 0; i < size; ++i) {
          sum += array[i];
     }    
     return sum / size;
 } 

 void use_mean()
 {
     int mean = compute_mean(0, 0);
 }

The problem from the previous snippet is fixed: the input variable 'size' is checked for the exceptional case of the zero constant value in line 3 and prevents the division from happening in this specific case.

Related checkers

External guidance

Security training

Application security training materials provided by Secure Code Warrior.

Business Logic Training Video - Test your skills with a training example

Extension

This checker can be extended through the Klocwork knowledge base. See Tuning C/C++ analysis for more information.