CS.PROP.LOCK

Lock both when either set or get is locked for a property.

This rule triggers whenever a property has both get and set methods and one of the following conditions holds:

Only one of the methods uses a lock and the other does not.
Both of them use lock, but lock on different objects.

Vulnerability and risk

If one of the methods in a property requires a lock, then it is very likely that the other one also needs it. Not locking can lead to issues that are very hard to detect and debug since the issues are usually not easy to reproduce.

Vulnerable code example

Copy

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
  //VIOLATION CASE
  public class Class1
  {
      private object a;
      private object DeadBolt = new object();
      public object SomeObject
      {
          get
          {
             lock (DeadBolt)
             {
                 return a;
             }
         }
         set
         {
             a = value;
         }
     }
 }

Fixed code example

Copy

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
  //FIXED CASE
  public class Class1
  {
      private object a;
      private object DeadBolt = new object();
      public object SomeObject
      {
          get
          {
             lock (DeadBolt)
             {
                 return a;
             }
         }
         set
             {
             lock (DeadBolt)
             {
                 a = value;
             }
         }
     }
 }