Function address is used instead of a call to function

The CWARN.FUNCADDR checker finds instances in which a function address is used unexpectedly as a logical condition or as an operand in an arithmetic or logical operation. Typically, these situations occur when the designer intended a call to the function and round brackets were lost.

Vulnerability and risk

In these cases, the compiler will take the address instead of calling the function. The address is never zero, and therefore always true, causing unexpected program behavior.

Vulnerable code example

1  int get0() { return 0; }
2  void test(Boolean b) {
3      if (get0)                                
4          return;
5  }

In this example, Klocwork flags line 3, in which an intended call to get0() becomes a function address used as a condition.