REDUN.EQ

A redundant operation is one that does not have any effect, such as

• an assignment of a variable to itself
• use of an expression that will be evaluated to a constant such as a/a
• use of an expression that can be reduced to one operand such as a & a

Even if this is not an error on its own, it may indicate a larger error in the code. A REDUN.EQ warning is reported for a suspicious call to equals() with the same object on both sides. Normally, equals() returns true to the same objects.

Example 1

9
10
11
12
13
14
15
      public int test() {
         String s = "String";
         if (s.equals(s)) {
             return 1;
         }
         return 0;
     }

REDUN.EQ is reported for line 11: Suspicious equals() called with 's' on both sides.

External guidance

• CWE-571: Expression is Always True

Security training

Application security training materials provided by Secure Code Warrior.

• Business Logic Training Video - Test your skills with a training example