RLK.SQLCON
RLK (Resource Leak) issues are reported when resources are allocated but not properly disposed after use. Failing to properly dispose a resource can lead to such problems as:
- too many files being open
- an application not being able to access a temporary file when it is needed
RLK.SQLCON indicates that a SQL connection is not closed on exit.
Vulnerability and risk
Resources such as streams, connections and graphic objects must be explicitly closed. The close operation can unblock transactions or flush file changes in the file system. While a resource will eventually be closed by the garbage collector, resource exhaustion can occur before garbage collection starts. Depending on the nature of the resource, various exceptions will be thrown on a failed attempt to allocate another resource, for example: java.io.FileNotFoundException: Too many open files or too many database connections.
Mitigation and prevention
Explicitly close all resources that have the close method, even those that you think are not doing anything significant. Future code changes will then be safe from such errors.
Example 1
public List<Integer> getActiveIDs() throws SQLException {
Connection con = DriverManager.getConnection("http://");
Statement statement = con.createStatement();
ResultSet rs = statement.executeQuery("SELECT * FROM table");
final List<Integer> result = new ArrayList<Integer>();
while (rs.next()) {
if (rs.getBoolean("active")) {
result.add(rs.getInt("id"));
}
}
return result;
}RLK.SQLCON is reported for the snippet on line 14: connection 'con' is not closed on exit.
Related checkers
External guidance
Extension
This checker can be extended through the Klocwork knowledge base. See Tuning Java analysis for more information.
