SV.UMC.EXIT
A web application should not make calls to System.exit() or Runtime.exit(). Even if it is "dead" code, or has no permission to shut down the Java Virtual Machine, the code is probably leftover debug code, or code left from a non-J2EE application.
Vulnerability and risk
System.exit() and Runtime.exit() can shut down the Java Virtual Machine. This might lead to a Denial of Service attack.
Klocwork security vulnerability (SV) checkers identify calls that create potentially dangerous data; these calls are considered unsafe sources. An unsafe source can be any data provided by the user, since the user could be an attacker or has the potential for introducing human error.
Mitigation and prevention
Calls to System.exit() and Runtime.exit() should be removed. An appropriate error handling should be implemented.
Example 1
public void doPost(HttpServletRequest request,
HttpServletResponse response) throws IOException,
ServletException {
doProcessRequest(request, response);
}
public void doGet(HttpServletRequest request,
HttpServletResponse response) throws IOException,
ServletException {
doProcessRequest(request, response);
}
// called from servlet
private void doProcessRequest(HttpServletRequest request,
HttpServletResponse response) throws IOException,
ServletException {
if ("shutdown".equals(request.getParameter("action"))) {
System.exit(1);
}
doCreatePage(request, response);
// ...
}SV.UMC.EXIT is reported for call on line 31: 'java.lang.System.exit()' method call should not be used in servlets code
